-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Magic Links: Refactor Authentication Mode to handle auth view definitions #1195
Merged
charliescheer
merged 11 commits into
feature/1187-magic-links
from
charlie/magic-links-ui-mk3
Jul 24, 2024
Merged
Magic Links: Refactor Authentication Mode to handle auth view definitions #1195
charliescheer
merged 11 commits into
feature/1187-magic-links
from
charlie/magic-links-ui-mk3
Jul 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
jleandroperez
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!! For the record, few details in here, which have been already fixed in the follow up PR, so let's move this one along!!
charliescheer
merged commit Jul 24, 2024
aa04da5
into
feature/1187-magic-links
9 of 10 checks passed
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Primarily this PR doesn't do much that is visible, but it is laying the ground work to continuing updating the auth views to the new designs and layouts, so we can add magic links.
So in this PR I have:
This shouldn't look too much different from the current state of the auth views, but because so many things have moved around here we should confirm that it all still works.
Test
Review
(Required) Add instructions for reviewers. For example:
Release